Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dart base image #32

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Conversation

josephswanson-wf
Copy link

Ultimate problem:

  • sniping smithy-runner-generator

How it was fixed:

  • use dart base image

Testing suggestions:

  • ensure CI / Travis passes

Potential areas of regression:

  • 😕

FYA: @michaelcarter-wf @travisreed-wf @dustinlessard-wf @bradbenjamin-wf

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

@semveraudit-wf
Copy link

Public API Changes

No changes to the public API found for commit 2d1e8ac

Showing results for 2d1e8ac

Powered by semver-audit-service. Please report any problems by filing an issue.
Reported by the dart semver audit client 1.4.0
Browse public API.

@codecov-io
Copy link

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          12       12           
  Lines         714      714           
=======================================
  Hits          657      657           
  Misses         57       57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e7bb5...2d1e8ac. Read the comment docs.

@jeffhall-wk
Copy link

+1

@jeffhall-wk
Copy link

+10 CI checks passed

@josephswanson-wf
Copy link
Author

@Workiva/release-management-pp

@jeffhall-wk
Copy link

jeffhall-wk commented Nov 2, 2018

@michaelcarter-wf is passing CI enough to merge this?

@michaelcarter-wf
Copy link

yes!

@michaelcarter-wf
Copy link

+10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants