-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated commands with new dart commands #49
Conversation
Merge Requirements Met ✅Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment. General InformationTicket(s): None found in title Reviewers: blakeroberts-wk, keruitan-wk Additional InformationWatchlist Notifications: None
Note: This is a shortened report. Click here to view Rosie's full evaluation. |
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Public API ChangesNo changes to the public API found for commit 5e548cb Showing results for 5e548cb
|
QA +1 |
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
This Sourcegraph batch replaces deprecated commands from the Dart SDK with the new ones.
All new CLI commands now live under the main
dart
executable. See this issue for the detailsdart-lang/sdk#46100
This PR might need to be checked or tweaked for possible errors in the arguments to
dart analyze
anddart format
since they take slightly different arguments than the original.In most cases for analyze all the arguments can be removed and it can just be
dart analyze
.Some of the argument changes were difficult to match and replace in an automated way. Since
there are only a few places that might break, it'll be easier to let the batch create the PR
and then manually adjust them.
Argument changes for dartfmt -> dart format
-w
should be removed automatically since overwriting files is now the default. But, if you spot one, remove it.--dry-run
is not a supported argument now. Replace with--set-exit-if-changed -o none
repos that look like they will need updates for dart format
Argument changes for dartanalyzer -> dart analyze
--no-hints
and--no-lints
are removedrepos that look like they will need updates for dart analyze
QA steps:
dart analyze
ordart format
check the argumentsCreated by Sourcegraph batch change
Workiva/dart_commands
.