Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to node 10.x, npm 6.4.x, webpack 4.4.27, webpack-dev-server 3.1.5 and firebase 5.10.1 #311

Merged
merged 2 commits into from
Apr 28, 2019
Merged

Update to node 10.x, npm 6.4.x, webpack 4.4.27, webpack-dev-server 3.1.5 and firebase 5.10.1 #311

merged 2 commits into from
Apr 28, 2019

Conversation

phaze9
Copy link
Contributor

@phaze9 phaze9 commented Apr 28, 2019

No description provided.

@phaze9
Copy link
Contributor Author

phaze9 commented Apr 28, 2019

Travis uses:
$ node --version
v12.0.0
$ npm --version
6.9.0

I ran into this when trying to npm install with above versions:
grpc/grpc-node Fails to build with node.js v12.0.0 release #834 grpc/grpc-node#834

@WuTheFWasThat
Copy link
Owner

unfortunate, should be able to fix travis to use the same versions though! looks good to me, assuming CI gets fixed

@WuTheFWasThat
Copy link
Owner

thanks (for onlookers, will re-verify the package-lock.json change)

@WuTheFWasThat WuTheFWasThat merged commit 8e335c7 into WuTheFWasThat:master Apr 28, 2019
@phaze9 phaze9 deleted the updates branch July 28, 2019 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WuTheFWasThat WuTheFWasThat WuTheFWasThat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phaze9 @WuTheFWasThat