Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AntiKnockback to the level of reverse AntiKnockback #907

Closed
wants to merge 1 commit into from
Closed

Conversation

mdenials
Copy link
Contributor

Description

Reverse AntiKnockback
Can bypass anticheat checks

Copy link

coderabbitai bot commented Nov 27, 2023

Walkthrough

Walkthrough

The update to the AntiKnockbackHack class in the Wurst Client mod for Minecraft expands the user's ability to customize the strength of the anti-knockback effect. The sliders for horizontal and vertical knockback resistance now allow for zero resistance, effectively disabling the anti-knockback feature, and the maximum resistance has been doubled, providing users with the option to have a stronger anti-knockback effect than was previously possible.

Changes

File Path Change Summary
.../hacks/AntiKnockbackHack.java Expanded the range of hStrength and vStrength settings, with minimum values now starting at 0 (previously 0.01) and maximum values increased to 2 (previously 1).

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between d42d872 and 623e363.
Files selected for processing (1)
  • src/main/java/net/wurstclient/hacks/AntiKnockbackHack.java (1 hunks)
Additional comments: 2
src/main/java/net/wurstclient/hacks/AntiKnockbackHack.java (2)
  • 21-29: The changes to the hStrength and vStrength settings correctly expand the range of values to allow more precise adjustments to knockback strength.

  • 21-32: > Note: This review was outside the patches, and no patch overlapping with it was found. Original lines [41-49]

The logic in the onKnockback method correctly applies the strength settings to the knockback event.

@mdenials mdenials changed the title Update AntiKnockbackHack.java Improve AntiKnockback to the level of reverse AntiKnockback Nov 27, 2023
@mdenials mdenials closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant