Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse Antiknockback improvement #908

Closed
wants to merge 1 commit into from
Closed

Reverse Antiknockback improvement #908

wants to merge 1 commit into from

Conversation

mdenials
Copy link
Contributor

Reverse values
Can bypass some of AntiCheats

Copy link

coderabbitai bot commented Nov 27, 2023

Walkthrough

Walkthrough

The update to the AntiKnockbackHack class in the Wurst Client extends the anti-knockback feature's capabilities. Previously, the hack allowed users to negate knockback effects up to 100%, effectively standing still when hit. The new changes double the potential strength, enabling reverse knockback, where players can now set the hack to push them in the opposite direction of incoming attacks, up to 200% strength.

Changes

File Path Change Summary
.../hacks/AntiKnockbackHack.java Increased the maximum value for horizontal and vertical knockback strength from 100% to 200% and updated the descriptions to include reverse knockback functionality.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between d42d872 and cc8614d.
Files selected for processing (1)
  • src/main/java/net/wurstclient/hacks/AntiKnockbackHack.java (1 hunks)
Additional comments: 1
src/main/java/net/wurstclient/hacks/AntiKnockbackHack.java (1)
  • 20-29: The SliderSetting changes and descriptions are correctly implemented to allow for reverse knockback.

@Alexander01998 Alexander01998 added type:enhancement New feature or request area:settings Improves the settings of existing features. category:combat labels Nov 27, 2023
@Alexander01998 Alexander01998 added this to the v7.40 milestone Nov 28, 2023
Alexander01998 added a commit that referenced this pull request Nov 28, 2023
@Alexander01998 Alexander01998 added the status:merged This pull request has been merged, even if GitHub says otherwise. label Nov 28, 2023
@mdenials mdenials closed this by deleting the head repository Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:settings Improves the settings of existing features. category:combat status:merged This pull request has been merged, even if GitHub says otherwise. type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants