-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial changer not working #18
Comments
Can you share your website link? |
Already got the error. The problem is that DOMContentload triggers when the site itself is loaded - not when the site is really loaded(the time where theres this loading circle). That way it cant find the tutorial item and cant change its content. |
That does not seem to be the issue. I tried putting it in the header advertising area (which loads after the loading circle is complete if I'm not mistaken), changed the DOMContentLoaded to a window.AddEventListener('load'), and I tried adding the script directly in the head and body areas. I'm not sure what's causing the issue, I suspect caching (the script getting executed only once and then, when the main page is reloaded, not loaded for a reason) but I haven't been able to find a workaround. |
I'll include the best I could get to run. This time it stays consistent with page changes, but hard refreshing may still break it. |
Well for me it worked to just add a delay. Best way of course is to update the render list thingy like Hans, but idk |
Oh that is interesting. Does my update work for you, if not, do you think you could contribute the change you made with the delay?
There are always better solutions, yes, and I imagine Hans as a much more experienced developer has written a better solution, I do not want to take a look at his code as I don't want to be opened to a copyright infringement. If no other solution works I could look up on how to update a render list and see how to apply that to VistaPanel. |
vPanel gets rendered from a list called "PAGE.appGroups". You just gotta modify the values. Thats it. Hans has a pretty convenient code for that, but coding your own shouldnt be too hard. |
vPanel gets rendered from a list called "PAGE.appGroups". You just gotta modify the values. Thats it. Hans has a pretty convenient code for that, but coding your own shouldnt be too hard. Havent tried the new code yet. |
Thanks! It is working sometimes and others not, I tested it myself. Bummer.
I know what you're mentioning, I'd seen it before in the source code view, but it never crossed my mind to modify that. I will look into it. Reopening the issue as it wasn't fixed at all. EDIT: I GOT IT! Pushing an update soon. Thanks for all the help! |
Just one more thing. If Ifastnet changes the itemlist, wont that brake? lol... |
If iFastNet changes the order of the item list, or the item list itself, I'll make sure to update it. I'll agree it wasn't the best solution, probably, but it was the quickest I could think of. In any case, it should be working as intended, and I doubt iFastNet is going to be updating that list anytime soon. |
The following changes were made: * Update credits, in a way that does not preserve needless comments. Enforce a consistent style on date writing. * Fix bug in AlterVP that caused the code for the credits description to be executed even if disabled. * Update Tutorial Link Changer, with a much better way of replacing the link, and fixing an issue where it would not be replaced sometimes. If you still face an issue, feel free to update #18 or make a new issue.
As a matter of fact, I just updated it in a way that ensures that, as long as the item list remains the same, it will work regardless of order. |
Tried some of the stuff here, and i think its awesome! The only problem I have is that the tutorial Link changer does not work. I can see the source code in the explorer, but it does not do anything.
The text was updated successfully, but these errors were encountered: