Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNAM-445:Create-studies-markdown #245

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Anfor
Copy link
Contributor

@Anfor Anfor commented Mar 13, 2020

No description provided.

@Anfor Anfor requested review from ysebiat and dsun0720 March 13, 2020 18:20
@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #245 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #245   +/-   ##
========================================
  Coverage    93.37%   93.37%           
========================================
  Files          196      196           
  Lines         2399     2399           
  Branches        51       51           
========================================
  Hits          2240     2240           
  Misses         159      159           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b197f52...16a2288. Read the comment docs.

Copy link
Contributor

@ysebiat ysebiat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont see in the example how and where Extractors, Transformers are used. You have to explicitly give examples of how they got involved by detailing every Extractor and Transformer is used and pointing to their definition in the Wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants