Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move submission_script.py also from binference to here #10

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

dachengx
Copy link
Collaborator

No description provided.

@@ -489,7 +489,7 @@ def flatten_function_args(combination, function_args):
raise Exception(
"You are overwriting function_args without knowing what is going on!"
)
elif key == "signal_rate_multiplier" and combination["signal_expectation"] is not None:
elif key == "signal_rate_multiplier" and combination.get("signal_expectation", None) is not None:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dachengx
Copy link
Collaborator Author

Sorry, I forgot to move submission_script.py also from binference to here.

@dachengx dachengx requested review from kdund and hammannr June 15, 2023 21:53
Copy link
Collaborator

@hammannr hammannr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch @dachengx !

@hammannr hammannr merged commit 308a62b into master Jun 15, 2023
@hammannr hammannr deleted the mv_files branch June 15, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants