Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #101

Merged
merged 16 commits into from
Oct 30, 2023
Merged

Improve documentation #101

merged 16 commits into from
Oct 30, 2023

Conversation

hammannr
Copy link
Collaborator

I started writing some documentation a couple of weeks ago but I can't find the time to finish it the next time.

However, I think the things that are added are already helpful for beginners. For this reason, I would suggest merging it at this stage and then we can pick it up from this point the next time someone has time to write something.

@hammannr hammannr added the documentation Improvements or additions to documentation label Oct 30, 2023
@hammannr hammannr requested review from kdund and dachengx October 30, 2023 10:22
@hammannr
Copy link
Collaborator Author

Do we really need doc8 to annoy us if the line is too long? I thought we discussed this at some point and anyway one would use alt+z in vscode or something for writing doc

@hammannr
Copy link
Collaborator Author

To check the compiled version you can have a look here 😊

@kdund
Copy link
Collaborator

kdund commented Oct 30, 2023

Do we really need doc8 to annoy us if the line is too long? I thought we discussed this at some point and anyway one would use alt+z in vscode or something for writing doc

Agreed, if possible I would remove all linting of docfiles.

kdund
kdund previously approved these changes Oct 30, 2023
Copy link
Collaborator

@kdund kdund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with merging

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Pull Request Test Coverage Report for Build 6694151483

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.741%

Totals Coverage Status
Change from base Build 6652053859: 0.0%
Covered Lines: 1333
Relevant Lines: 1453

💛 - Coveralls

@hammannr hammannr merged commit baca38e into main Oct 30, 2023
@hammannr hammannr deleted the improve_doc branch October 30, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants