Allow all computation names #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdund
commented
Nov 15, 2023
| "sensitivity", | ||
| ], | ||
| help="Type of computation, defined in YAML runner config file", | ||
| help=( |
There was a problem hiding this comment.
my IDE complains about """ block quotes, but the solution here seems way worse for readability surely?
There was a problem hiding this comment.
Especially the mixture of " and ' is a bit odd to read. Apart from that, I think this is ok. What would've been your preferred format?
There was a problem hiding this comment.
Ah got it. You want the names to have "" -- then I think this is fine.
Pull Request Test Coverage Report for Build 7029328329
💛 - Coveralls |
hammannr
approved these changes
Nov 27, 2023
| "sensitivity", | ||
| ], | ||
| help="Type of computation, defined in YAML runner config file", | ||
| help=( |
There was a problem hiding this comment.
Ah got it. You want the names to have "" -- then I think this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#115 -- the world is rich, and we can allow any computation name (though "threshold" is special, and others such as "collate results" may be in the future)