-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "piecewise" the default pdf interpolation #142
Conversation
Pull Request Test Coverage Report for Build 8087518258Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me-- any way to test?
@kdund you could add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked, and works, thanks @hammannr
Hey @hammannr . Maybe you could try to squash and merge next time. Then it is easier to track the change from a PR in the GitHub history. |
This PR makes
"piecewise"
the default pdf interpolation method. Before, the default was defined in blueice to"linear"
, which is only in certain limits compatible with theBlueiceDataGenerator
. TheBlueiceDataGenerator
is now only assigned if all sources have piecewise interpolation -- in the future we can add a suitable generator also for the linear interpolation case.