-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid prexing every key when adapt_likelihood_config_for_blueice #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Pull Request Test Coverage Report for Build 9688342366Details
💛 - Coveralls |
for more information, see https://pre-commit.ci
Pull Request Test Coverage Report for Build 9688343473Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9688343473Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9688353716Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9688354594Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9688366339Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9688365224Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9688404272Details
💛 - Coveralls |
dachengx
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FaroutYLq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is likely a bug introduced in #169. The original implementation was trying to prefix every field, as long as it happens to be an existing file after prefixing. You can see one example that this will lead to a problem.
Let's say you have defined the following sources in your statistical model yaml file:
in this example, with current alea it will complain a bug. In general, as long as your source name coincidence with a path name after prefixing, it will give an issue.
The issue took place inside
adapt_likelihood_config_for_blueice
. Before prefixing here,source
looks likeAfter, it becomes:
You can see that now the source name makes no sense.
In this patch solution, we try to avoid config keys that will in no way be interpreted as a path or filename, by making them into
ignore_keys
.