Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSG submission #189

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix OSG submission #189

merged 1 commit into from
Aug 26, 2024

Conversation

hammannr
Copy link
Collaborator

In #182 we added fit_strategy as an argument to the runner. Unfortunately, I missed to also add it to the shell script, which is called for submissions to OSG, which led to shifted arguments. This PR should fix the mismatch.

@hammannr hammannr requested review from dachengx and FaroutYLq August 26, 2024 09:52
@coveralls
Copy link

coveralls commented Aug 26, 2024

Pull Request Test Coverage Report for Build 10557605908

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.469%

Totals Coverage Status
Change from base Build 10288898289: 0.0%
Covered Lines: 1662
Relevant Lines: 1817

💛 - Coveralls

@hammannr hammannr merged commit ecb862a into main Aug 26, 2024
7 checks passed
@hammannr hammannr deleted the fix_osg_submission branch August 26, 2024 10:00
Copy link
Contributor

@FaroutYLq FaroutYLq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the headup. It looks correct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants