Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep only one Directory.SHARED_SCRATCH #222

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Keep only one Directory.SHARED_SCRATCH #222

merged 2 commits into from
Oct 1, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Oct 1, 2024

Close: #221

Remove self.scratch_dir because it is not needed. Generally speaking, for pegasus workflow building we only need a single Directory.SHARED_SCRATCH and a single Directory.LOCAL_STORAGE.

@dachengx dachengx requested a review from FaroutYLq October 1, 2024 19:38
FaroutYLq
FaroutYLq approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@FaroutYLq FaroutYLq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's clear enough. Thanks.

@dachengx dachengx marked this pull request as ready for review October 1, 2024 19:41
@coveralls
Copy link

coveralls commented Oct 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11132277581

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 89.563%
Totals Coverage Status
Change from base Build 11030194195: 0.05%
Covered Lines: 1682
Relevant Lines: 1878
💛 - Coveralls

@dachengx dachengx merged commit 8e6fd31 into main Oct 1, 2024
7 checks passed
@dachengx dachengx deleted the single_shared_scratch branch October 1, 2024 19:43
dachengx added a commit that referenced this pull request Oct 2, 2024
@dachengx
Revert "Keep only one Directory.SHARED_SCRATCH (#222)"
9f0a97d 
This reverts commit 8e6fd31.
@dachengx dachengx mentioned this pull request Oct 2, 2024
Merged
dachengx added a commit that referenced this pull request Oct 2, 2024
@dachengx
Revert "Keep only one Directory.SHARED_SCRATCH (#222)" (#223)
dcd4de0 
This reverts commit 8e6fd31.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FaroutYLq FaroutYLq FaroutYLq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The self.scratch_dir is invalid Directory.SHARED_SCRATCH
3 participants
@dachengx @coveralls @FaroutYLq