Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the workflow id to the folder in staging-davs #224

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Add the workflow id to the folder in staging-davs #224

merged 1 commit into from
Oct 3, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Oct 3, 2024

This will prevent output/scratch files related to different workflows putting in the same folder and being hard to distinguish.

Suggested in slack thread, sorry it has only internal access.

@dachengx dachengx requested a review from FaroutYLq October 3, 2024 02:59
@dachengx dachengx marked this pull request as ready for review October 3, 2024 02:59
@coveralls
Copy link

coveralls commented Oct 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11155093233

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.51%
Totals Coverage Status
Change from base Build 11148379587: 0.0%
Covered Lines: 1681
Relevant Lines: 1878
💛 - Coveralls

@dachengx dachengx merged commit 2ff9da0 into main Oct 3, 2024
7 checks passed
@dachengx dachengx deleted the append_workflow_id branch October 3, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FaroutYLq FaroutYLq Awaiting requested review from FaroutYLq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dachengx @coveralls