-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes all hash for parameters not used for each source, and for all… #37
Conversation
… efficiency parameters. This way, blueice will not cache pdfs for different values of these parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
pep8
alea/blueice_extended_model.py|160 col 28| WPS309 Found reversed compare order
alea/blueice_extended_model.py|160 col 29| E225 missing whitespace around operator
alea/blueice_extended_model.py|160 col 101| E501 line too long (140 > 100 characters)
alea/blueice_extended_model.py|161 col 1| S101 Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
alea/blueice_extended_model.py|161 col 101| E501 line too long (146 > 100 characters)
alea/blueice_extended_model.py|162 col 79| E231 missing whitespace after ','
alea/statistical_model.py|166 col 1| D102 Missing docstring in public method
alea/statistical_model.py|167 col 9| F841 local variable 'mus' is assigned to but never used
One detail I just noticed: The |
@kdund I had a first quick look: runs nicely and does what it's supposed to do 😊 I'll have a more detailed look later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdund thanks a lot for adding this! 😊 I only have a few minor comments and some questions on parts that I don't fully understand
This code produces only 4 cached PDFs (2 WIMP 2 ER):
and outputs:
`Computing/loading models on one core: 100%|█| 2/2 [00:0
Computing/loading models on one core: 100%|█| 2/2 [00:0
INFO:root:initing simulator, binned: False
INFO:root:initing simulator, binned: False
set signal eff to see effect on fit, should get wimp_rate_multiplier around 50:
({'wimp_mass': 50.0, 'livetime_sr0': 0.2, 'livetime_sr1': 1.0, 'wimp_rate_multiplier': 45.81721355528466, 'er_rate_multiplier': 1.1432726668929618, 'signal_efficiency': 0.20000990901055393}, -3111.486710614569)
{'er': 240.0, 'wimp': 0.0}
{'er': 240.0, 'wimp': 3.6}
{'er': 240.0, 'wimp': 12.0}
{'er': 240.0, 'wimp': 36.0}
`