Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover examples folder, update file indexing, add notebooks folder, remove legacies #61

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Jul 27, 2023

Following private discussion at https://xenonnt.slack.com/archives/C04JRF0AZTP/p1690266817770479.

The main idea is that GaussianModel is a well-defined and simple model to show a minimum subclass of StatisticalModel.

@dachengx dachengx requested review from kdund and hammannr July 27, 2023 13:52
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5681419214

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 17.964%

Totals Coverage Status
Change from base Build 5680931957: 0.03%
Covered Lines: 526
Relevant Lines: 2928

💛 - Coveralls

@github-actions
Copy link

Pull Request Test Coverage Report for Build 5681519848

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 17.964%

Totals Coverage Status
Change from base Build 5680931957: 0.03%
Covered Lines: 526
Relevant Lines: 2928

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jul 27, 2023

Pull Request Test Coverage Report for Build 5682154349

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+38.3%) to 56.257%

Totals Coverage Status
Change from base Build 5680931957: 38.3%
Covered Lines: 526
Relevant Lines: 935

💛 - Coveralls

Copy link
Collaborator

@hammannr hammannr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and runs! I'd suggest to get rid of legacy code with the same PR and then merge 😊

Copy link
Collaborator

@kdund kdund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur with @hammannr , what we want from the _ - files can be copy-pasted in according to need.

Copy link
Collaborator

@kdund kdund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@dachengx dachengx merged commit 85fad65 into main Jul 27, 2023
@dachengx dachengx deleted the recover_examples branch July 27, 2023 15:05
@dachengx dachengx changed the title Recover examples folder, update file indexing, add notebooks folder Recover examples folder, update file indexing, add notebooks folder, remove legacies Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants