Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lineage #11

Closed
HenningSE opened this issue Apr 12, 2023 · 5 comments
Closed

Lineage #11

HenningSE opened this issue Apr 12, 2023 · 5 comments

Comments

@HenningSE
Copy link
Collaborator

We have the option in strax to track certain config options in the lineage. For now, (almost?) all of them are not tracked. We need to evaluate which ones are so important that they need to be tracked.

@HenningSE HenningSE added this to the Necessary Changes milestone Apr 12, 2023
@jmosbacher
Copy link

I would advocate for tracking most if not all configs. The lineage hash is whats used for caching. Not tracking configs that have an effect on the output will result in inconsistent results depending on the previous simulation.

@HenningSE
Copy link
Collaborator Author

With #35 all configs are handled via straxen URLConfigs. With the implemented changes all config options will be tracked. If no objections, the issue can be closed when the PR is merged.

@ramirezdiego
Copy link
Collaborator

#35 was merged, but I admit I am not yet sure we want to track absolutely every setting, simply because some are legacy form the very early WFSim times and we might want to review that

@HenningSE
Copy link
Collaborator Author

#39 will update the S1 and S2 photon propagation plugins and remove unused config options. I think we can close this Issue as soon as the PR is merged.

@HenningSE
Copy link
Collaborator Author

PR was merged. Now all configs are tracked and actually used in the simulation. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants