-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URLConfigs, Volume Plugins, S1 Plugin Split, Removal of electron_cloud data_kind #35
Conversation
* Move S1 n_photon_hits calculation out of S1PhotonPropagation plugin in preparation for fastsim integration
This PR grew a bit compared to the initial task. These things have been changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After testing the notebook, I finally finished looking at all the code changes (there was a lot 😄), thanks for the patience.
To me this looks good and refines further the structure that we want, to deal with detector corrections and fast-sim implementation, also thanks to the extra couple of general plugins that you added. This is great work, @HenningSE :) !
Let's deal with the TOC and renaming issues in the next iterations, but merge all these changes now, so that we can already start working on top of the new structure.
This PR will:
@strax.takes_config
arguments bystraxen.URLConfig