New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We are per chunk simulation not per run #229

Closed

dachengx opened this issue May 30, 2024 · 0 comments · Fixed by #233

Contributor

dachengx commented May 30, 2024

fuse/fuse/plugins/pmt_and_daq/photon_pulses.py

Line 134 in d5dde95

pulse_ids["pulse_id"] = photon_id

pulse_id should not start at 0 if feed in the second or more chunks into compute .
We should do something like: https://github.com/XENONnT/straxen/blob/b8fe520deca55b8c5ac0cb53249b38639f0ae5de/straxen/plugins/events/events.py#L154

dachengx mentioned this issue

Make pulse_id continuous in chunks #233

Merged

5 tasks

ramirezdiego closed this as completed in #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment