Make pulse_id
continuous in chunks
#233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you submit this PR: make sure to put all XENONnT specific information in a wiki-note as the repo is publicly accessible
What does the code in this PR do / what does it improve?
Fix #229
And a problem with sorting of
photon_pulses
andpulse_ids
.In previous codes
fuse/fuse/plugins/pmt_and_daq/photon_pulses.py
Line 131 in 9baffd3
photon_pulses
is sorted before assigningphoton_id
topulse_ids
.Can you briefly describe how it works?
Similar to https://github.com/XENONnT/straxen/blob/b8fe520deca55b8c5ac0cb53249b38639f0ae5de/straxen/plugins/events/events.py#L154, first make an attribute
pulse_ids_seen
ofPulseWindow
, then update it for each chunk.Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable: