Separate above- and below-gate drift of electrons #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenningSE
requested changes
Apr 4, 2024
There was a problem hiding this comment.
Thanks for the PR @zihaoxu98! I have just some minor comments and will later test run the code.
|
For me the PR looks good! Thanks for implementing the requested changes! As soon as the corresponding config file PR is merged we can merge this one too. |
HenningSE
approved these changes
Apr 8, 2024
|
Thanks, @zihaoxu98! This looks good. See comments in https://github.com/XENONnT/private_nt_aux_files/pull/305 to fine-tune the configs setting for this part of the code. |
Pull Request Test Coverage Report for Build 8630166242Details
💛 - Coveralls |
ramirezdiego
approved these changes
Apr 10, 2024
|
@zihaoxu98 will this change also be applied to SR0 results? Then shall we change SR0 map? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly modifies the drift process, to be consistent with the definition from the study shown in this note. This requires an additional parameter liquid_level, which is added back in https://github.com/XENONnT/private_nt_aux_files/pull/305