-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional random seed as user input #179
Conversation
Pull Request Test Coverage Report for Build 8555588004Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HenningSE . Please add a test for this feature.
Thanks for the suggestion @dachengx. I added the following tests:
The last two tests are not specific to the changes in this PR but I think it does not hurt us to have them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HenningSE . All good with a small potential improvement.
With this PR we will give users the option to set the random seed manually. If you want to use this function, you need to set
deterministic_seed
toFalse
anduser_defined_random_seed
to the seed you want to use.