Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test full chain in multiple chunks and clean up input tests #184

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

mhliu0001
Copy link
Contributor

Previously, the tests only simulated one chunk. This PR adds tests for multiple chunks.

Also, this PR rewrites test_input.py to capture exceptions more elegantly.

@coveralls
Copy link

coveralls commented Mar 29, 2024

Pull Request Test Coverage Report for Build 8750603288

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 71.643%

Totals Coverage Status
Change from base Build 8728278929: 0.1%
Covered Lines: 2097
Relevant Lines: 2927

💛 - Coveralls

@mhliu0001 mhliu0001 changed the title Add more tests and rewrite test_input.py with unittest assertion functions Add more tests Mar 29, 2024
@mhliu0001 mhliu0001 marked this pull request as draft March 29, 2024 20:05
@mhliu0001
Copy link
Contributor Author

I will add some more tests to increase the coverage.

@HenningSE
Copy link
Collaborator

Hi @mhliu0001, what is the status of this PR?

@mhliu0001
Copy link
Contributor Author

Hi @HenningSE , I think this can be merged now if you want. My original plan was to add some tests with empty instructions, but for the moment this is not the priority.

@HenningSE HenningSE changed the title Add more tests Test full chain in multiple chunks and clean up input tests Apr 19, 2024
@HenningSE HenningSE marked this pull request as ready for review April 19, 2024 08:23
@HenningSE
Copy link
Collaborator

Thanks for the PR @mhliu0001 . I re-enabled the single chunk full chain tests (more tests won't hurt us) and will merge this PR when the checks are successful. We can add more tests like you suggested in future PRs.

@HenningSE HenningSE merged commit c310203 into main Apr 19, 2024
4 checks passed
@HenningSE HenningSE deleted the more_tests branch April 19, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants