Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embellish some codes #188

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Embellish some codes #188

merged 4 commits into from
Apr 10, 2024

Conversation

dachengx
Copy link
Contributor

@dachengx dachengx commented Apr 10, 2024 •
edited
Loading

  1. Make the depends_on in the order of lower to higher plugin
  2. Remove comma from dtype
  3. Remove comma from help
  4. Add more information in help but can not finish
  5. straxilize data_kind

@ramirezdiego
Copy link
Collaborator

Looks good, @dachengx! But only approving with full stomach 😁

HenningSE
HenningSE reviewed Apr 10, 2024
View reviewed changes
HenningSE
HenningSE approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@HenningSE HenningSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks @dachengx!

@coveralls
Copy link

coveralls commented Apr 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8630016956

Details

  • 43 of 43 (100.0%) changed or added relevant lines in 17 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 68.472%
Files with Coverage Reduction New Missed Lines %
fuse/plugins/pmt_and_daq/pmt_afterpulses.py 1 92.63%
fuse/common.py 2 51.15%
Totals Coverage Status
Change from base Build 8629984587: -0.01%
Covered Lines: 1833
Relevant Lines: 2677
💛 - Coveralls

@dachengx dachengx merged commit e23c6ab into main Apr 10, 2024
4 checks passed
@dachengx dachengx deleted the embellishing branch April 10, 2024 10:59
@dachengx dachengx mentioned this pull request Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenningSE HenningSE HenningSE approved these changes

@ramirezdiego ramirezdiego Awaiting requested review from ramirezdiego

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dachengx @ramirezdiego @coveralls @HenningSE