Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale S2 pattern map to correct S2 AFT #196

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Scale S2 pattern map to correct S2 AFT #196

merged 6 commits into from
Apr 24, 2024

Conversation

zihaoxu98
Copy link
Contributor

@zihaoxu98 zihaoxu98 commented Apr 23, 2024

This PR modifies the code of s2_aft_rescaling of s2 pattern by setting dead PMTs to be zero before rescaling, otherwise the aft could be changed even after the rescaling.

@zihaoxu98 zihaoxu98 marked this pull request as ready for review April 23, 2024 07:40
@coveralls
Copy link

coveralls commented Apr 23, 2024

Pull Request Test Coverage Report for Build 8801424776

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.696%

Totals Coverage Status
Change from base Build 8797649823: 0.0%
Covered Lines: 2105
Relevant Lines: 2936

💛 - Coveralls

@zihaoxu98 zihaoxu98 marked this pull request as draft April 23, 2024 10:48
@zihaoxu98 zihaoxu98 marked this pull request as ready for review April 24, 2024 00:59
Copy link
Collaborator

@HenningSE HenningSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me! I was thinking if we would need to bump the plugin versions to reflect the made changes in the lineage but here we change the default URLConfig to include the turned off PMTs so the lineage should be automatically updated.

@ramirezdiego ramirezdiego merged commit f08d6ce into main Apr 24, 2024
4 checks passed
@ramirezdiego ramirezdiego deleted the s2_aft branch April 24, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants