Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tight coincidence and peak tagging in ClusterTagging #210

Merged
merged 10 commits into from
May 3, 2024

Conversation

zihaoxu98
Copy link
Contributor

@zihaoxu98 zihaoxu98 commented May 1, 2024

What does the code in this PR do / what does it improve?

This PR adds some fields in ClusterTagging plugin based only on peaks. The new fields don't tell you whether the peaks are main/alternative but only S0/S1/S2 and the tight coincidence of the peaks. This definition is consistent with the reconstruction efficiency.

I also added a new parameter photon_finding_window as the window of touching_window_split. This is because that there are some photons reconstructed as peaks successfully, but the peaks' start and end times are both later than the photon time (i.e. the cluster time) thus it cannot be tagged if we simply use window=0. Currently it's set to 200ns, meaning peaks' start and end times are extended both 200ns to find photons.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

  • Update the docstring(s)
  • Bump plugin version(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the GitHub open issues?

@coveralls
Copy link

coveralls commented May 1, 2024

Pull Request Test Coverage Report for Build 8935626128

Details

  • 4 of 13 (30.77%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 71.506%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fuse/plugins/truth_information/cluster_tagging.py 4 13 30.77%
Files with Coverage Reduction New Missed Lines %
fuse/plugins/truth_information/cluster_tagging.py 1 32.5%
Totals Coverage Status
Change from base Build 8935611717: -0.1%
Covered Lines: 2108
Relevant Lines: 2948

💛 - Coveralls

@HenningSE HenningSE merged commit 44e9650 into main May 3, 2024
4 checks passed
@HenningSE HenningSE deleted the photon_finding branch May 3, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants