Skip to content

Commit

Permalink
Merge pull request #12 from lefinal/350-fix-sql-generation-for-json-r…
Browse files Browse the repository at this point in the history
…aw-message

fix: fix sql generation for json.RawMessage
  • Loading branch information
XIELongDragon authored Oct 6, 2024
2 parents c20bc99 + 1d09d8e commit 1dba8da
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
3 changes: 3 additions & 0 deletions sqlgen/expression_sql_generator.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package sqlgen

import (
"database/sql/driver"
"encoding/json"
"reflect"
"strconv"
"time"
Expand Down Expand Up @@ -148,6 +149,8 @@ func (esg *expressionSQLGenerator) reflectSQL(b sb.SQLBuilder, val interface{})
switch t := val.(type) {
case []byte:
esg.literalBytes(b, t)
case json.RawMessage:
esg.literalBytes(b, t)
case []exp.CommonTableExpression:
esg.commonTablesSliceSQL(b, t)
default:
Expand Down
7 changes: 7 additions & 0 deletions sqlgen/expression_sql_generator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package sqlgen_test

import (
"database/sql/driver"
"encoding/json"
"fmt"
"regexp"
"testing"
Expand Down Expand Up @@ -231,6 +232,12 @@ func (esgs *expressionSQLGeneratorSuite) TestGenerate_BytesTypes() {

expressionTestCase{val: []byte("Hello'"), sql: "'Hello'''"},
expressionTestCase{val: []byte("Hello'"), sql: "?", isPrepared: true, args: []interface{}{[]byte("Hello'")}},

expressionTestCase{val: json.RawMessage("Hello"), sql: "'Hello'"},
expressionTestCase{val: json.RawMessage("Hello"), sql: "?", isPrepared: true, args: []interface{}{[]byte("Hello")}},

expressionTestCase{val: json.RawMessage("Hello'"), sql: "'Hello'''"},
expressionTestCase{val: json.RawMessage("Hello'"), sql: "?", isPrepared: true, args: []interface{}{[]byte("Hello'")}},
)
}

Expand Down

0 comments on commit 1dba8da

Please sign in to comment.