Pass through itemset ref case

XLSForm · May 10, 2023 · 22d885c · 22d885c
1 parent 62c26ce
commit 22d885c
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/pyxform/validators/pyxform/parameters_generic.py b/pyxform/validators/pyxform/parameters_generic.py
@@ -4,6 +4,8 @@
 
 PARAMETERS_TYPE = Dict[str, Any]
 
+CASE_SENSITIVE_VALUES = ["label", "value"]
+
 
 def parse(raw_parameters: str) -> PARAMETERS_TYPE:
     parts = raw_parameters.split(";")
@@ -21,7 +23,7 @@ def parse(raw_parameters: str) -> PARAMETERS_TYPE:
             )
         k, v = param.split("=")[:2]
         key = k.lower().strip()
-        params[key] = v.lower().strip()
+        params[key] = v.strip() if key in CASE_SENSITIVE_VALUES else v.lower().strip()
 
     return params
 

diff --git a/tests/test_external_instances_for_selects.py b/tests/test_external_instances_for_selects.py
@@ -242,6 +242,24 @@ def test_param_value_and_label_validation(self):
                             error__contains=[msg],
                         )
 
+    def test_param_value_case_preserved(self):
+        """Should find that parameters value/label override the default itemset name/label with case preserved."""
+        md = """
+        | survey |                                        |         |         |                      |
+        |        | type                                   | name    | label   | parameters           |
+        |        | select_one_from_file cities{ext}       | city    | City    | value=VAL, label=lBl |
+        """
+        for ext, xp_city, xp_subs in self.xp_test_args:
+            with self.subTest(msg=ext):
+                self.assertPyxformXform(
+                    name="test",
+                    md=md.format(ext=ext),
+                    xml__xpath_match=[
+                        xp_city.model_external_instance_and_bind(),
+                        xp_city.body_itemset_nodeset_and_refs(value="VAL", label="lBl"),
+                    ],
+                )
+
 
 class TestSelectOneExternal(PyxformTestCase):
     """