-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 477 trigger in repeat #478
Conversation
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
=======================================
Coverage 83.63% 83.63%
=======================================
Files 25 25
Lines 3641 3641
Branches 846 846
=======================================
Hits 3045 3045
Misses 452 452
Partials 144 144
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a full review, just a pre-review looking only at the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks great to me.
@lognaturel - Do you have a timetable to tag a new version with this update? |
@lognaturel proposed to release shortly with two other features still to be
merged. I believe we're mainly waiting for me to review a PR.
…On Fri, Nov 20, 2020 at 9:53 AM pbowen-oc ***@***.***> wrote:
@lognaturel <https://github.com/lognaturel> - Do you have a timetable to
tag a new version with this update?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#478 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEZFFSQ7TJII5QNQK45EDTSQ2NIJANCNFSM4TUTIR5A>
.
--
*Pushing data since 2012.*
Enketo <https://enketo.org> | LinkedIn
<http://www.linkedin.com/company/enketo-llc> | GitHub
<https://github.com/enketo> | Twitter <https://twitter.com/enketo>
| Blog <http://blog.enketo.org>
--
--
*Revolutionizing data collection since 2012.*
Enketo
<https://enketo.org/> | LinkedIn
<http://www.linkedin.com/company/enketo-llc> | GitHub
<https://github.com/enketo> | Twitter <https://twitter.com/enketo>
| Blog <http://blog.enketo.org/>
|
Closes #
Fix #477
Why is this the best possible solution? Were any other approaches considered?
The simplest one.
What are the regression risks?
None.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
tests_v1
nosetests
and verified all tests passblack pyxform
to format code