Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 477 trigger in repeat #478

Merged
merged 4 commits into from
Nov 18, 2020
Merged

Fix 477 trigger in repeat #478

merged 4 commits into from
Nov 18, 2020

Conversation

gushil
Copy link
Contributor

@gushil gushil commented Nov 13, 2020

Closes #
Fix #477

Why is this the best possible solution? Were any other approaches considered?

The simplest one.

What are the regression risks?

None.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests_v1
  • run nosetests and verified all tests pass
  • run black pyxform to format code
  • verified that any code or assets from external sources are properly credited in comments

@codecov-io
Copy link

codecov-io commented Nov 13, 2020

Codecov Report

Merging #478 (53c23cf) into master (9520bd2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #478   +/-   ##
=======================================
  Coverage   83.63%   83.63%           
=======================================
  Files          25       25           
  Lines        3641     3641           
  Branches      846      846           
=======================================
  Hits         3045     3045           
  Misses        452      452           
  Partials      144      144           
Impacted Files Coverage Δ
pyxform/question.py 93.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9520bd2...53c23cf. Read the comment docs.

Copy link
Contributor

@MartijnR MartijnR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a full review, just a pre-review looking only at the tests.

pyxform/tests_v1/test_trigger.py Outdated Show resolved Hide resolved
@gushil gushil requested a review from MartijnR November 15, 2020 14:28
pyxform/tests_v1/test_trigger.py Outdated Show resolved Hide resolved
pyxform/question.py Outdated Show resolved Hide resolved
pyxform/tests_v1/test_trigger.py Outdated Show resolved Hide resolved
@gushil gushil requested a review from MartijnR November 17, 2020 08:46
Copy link
Contributor

@MartijnR MartijnR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks great to me.

@MartijnR MartijnR requested a review from lognaturel November 18, 2020 16:48
@lognaturel lognaturel merged commit 4d9decd into XLSForm:master Nov 18, 2020
@lognaturel
Copy link
Contributor

Thanks @MartijnR, @gushil!

@pbowen-oc
Copy link

@lognaturel - Do you have a timetable to tag a new version with this update?

@MartijnR
Copy link
Contributor

MartijnR commented Nov 20, 2020 via email

@gushil gushil deleted the fix-477-trigger-in-repeat branch December 8, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger referring to repeat question has relative ref attribute
5 participants