Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for dynamic defaults now more annoying than helpful #526

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

yanokwa
Copy link
Contributor

@yanokwa yanokwa commented Mar 24, 2021

Closes #523

Why is this the best possible solution? Were any other approaches considered?

Narrowest fix possible

What are the regression risks?

No major ones.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests_v1
  • run nosetests and verified all tests pass
  • run black pyxform to format code
  • verified that any code or assets from external sources are properly credited in comments

@yanokwa yanokwa force-pushed the remove-dynamic-default-warning branch from 950753c to a9def04 Compare March 24, 2021 04:08
@codecov-io
Copy link

Codecov Report

Merging #526 (a9def04) into master (bee9654) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
- Coverage   83.92%   83.84%   -0.08%     
==========================================
  Files          25       23       -2     
  Lines        3713     3554     -159     
  Branches      865      834      -31     
==========================================
- Hits         3116     2980     -136     
+ Misses        452      431      -21     
+ Partials      145      143       -2     
Impacted Files Coverage Δ
pyxform/xls2json.py 78.52% <ø> (-0.13%) ⬇️
pyxform/__init__.py
pyxform/utils.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee9654...a9def04. Read the comment docs.

@yanokwa yanokwa merged commit 43ea039 into XLSForm:master Mar 26, 2021
@yanokwa yanokwa deleted the remove-dynamic-default-warning branch October 13, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove warning for dynamic defaults
3 participants