Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"account_nfts" with unassociated marker is returning empty account_nfts instead of error. #1497

Closed
mounikakun opened this issue Jun 27, 2024 · 0 comments · Fixed by #1589
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mounikakun
Copy link
Collaborator

Issue Description

"account_nfts" with unassociated marker(i.e., marker from another method "account_channels") is not returning error.

Not sure if the response should error out or return empty account_nfts. As rippled is fixing the issue, will have to replicate it in Clio.

Steps to Reproduce

Sample request:
{ "method": "account_nfts", "params": [ { "account":"ra1egD7jzyZWhcDaPD1eFPKzdSMVQCTsXM", "marker": "10394D3EA937A85A4482D2071412A33C8582A6EB4C3B7FD59C76012D83AC08C6" } ] }

Expected Result

Current response matches with rippled. If there's a fix for https://github.com/XRPLF/rippled/issues/4314 which returns error, Clio should replicate it.

Actual Result

{ "result": { "ledger_hash": "41560CD72E0E9B68BC8D9A8E261695392C22B3E115E0796119DC40B28C26E242", "ledger_index": 1936194, "validated": true, "account": "ra1egD7jzyZWhcDaPD1eFPKzdSMVQCTsXM", "account_nfts": [], "limit": 100, "status": "success" }, "warnings": [ { "id": 2001, "message": "This is a clio server. clio only serves validated data. If you want to talk to rippled, include 'ledger_index':'current' in your request" } ] }

Environment

Supporting Files

@mounikakun mounikakun added the bug Something isn't working label Jun 27, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Clio Jun 27, 2024
@kuznetsss kuznetsss added this to the 2.3 milestone Jun 28, 2024
@kennyzlei kennyzlei assigned Kassaking7 and unassigned Kassaking7 Jul 12, 2024
PeterChen13579 added a commit that referenced this issue Aug 27, 2024
Fixes [#1497](#1497)
Mimics the behavior of the [fix on Rippled
side](XRPLF/rippled#5045)
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Merged in Clio Aug 27, 2024
PeterChen13579 added a commit that referenced this issue Aug 27, 2024
Fixes [#1497](#1497)
Mimics the behavior of the [fix on Rippled
side](XRPLF/rippled#5045)
PeterChen13579 added a commit that referenced this issue Aug 27, 2024
Fixes [#1497](#1497)
Mimics the behavior of the [fix on Rippled
side](XRPLF/rippled#5045)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Merged
Development

Successfully merging a pull request may close this issue.

4 participants