Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Subscription Manager uses async framework #1605

Merged
merged 6 commits into from
Aug 16, 2024

Conversation

cindyyan317
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 16 lines in your changes missing coverage. Please review.

Project coverage is 69.85%. Comparing base (49e9d5e) to head (4211a04).
Report is 5 commits behind head on develop.

Files Patch % Lines
src/feed/SubscriptionManager.hpp 31.25% 4 Missing and 7 partials ⚠️
src/feed/impl/BookChangesFeed.hpp 0.00% 0 Missing and 1 partial ⚠️
src/feed/impl/LedgerFeed.hpp 0.00% 0 Missing and 1 partial ⚠️
src/feed/impl/ProposedTransactionFeed.cpp 85.71% 1 Missing ⚠️
src/feed/impl/ProposedTransactionFeed.hpp 50.00% 0 Missing and 1 partial ⚠️
src/feed/impl/TransactionFeed.cpp 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1605      +/-   ##
===========================================
+ Coverage    69.61%   69.85%   +0.24%     
===========================================
  Files          257      260       +3     
  Lines         9879     9917      +38     
  Branches      5457     5466       +9     
===========================================
+ Hits          6877     6928      +51     
- Misses        1588     1589       +1     
+ Partials      1414     1400      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cindyyan317 cindyyan317 merged commit 4cbd3f5 into XRPLF:develop Aug 16, 2024
17 checks passed
@cindyyan317 cindyyan317 deleted the async_sub2 branch August 16, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants