Unify json #992
Merged
Unify json #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuznetsss
approved these changes
Nov 20, 2023
This was referenced Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify transaction json for v2, the changes include:
1 tx
2 transaction_entry
3 account_tx
4 ledger
5 nfts_history (Clio only)
#962
Fix mismatches for v1 #981 #982 close_time_iso
One thing worth to mention:
Currently the ledger_index in ledger handler is a string. Rippled might fix it in 2.0. We will keep an eye on it and change accordingly. For now, let us get the current changes tested.