Address review

XRPLF · Apr 16, 2024 · 195194b · 195194b
1 parent 39eaa7e
commit 195194b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/external/README.md b/external/README.md
@@ -1,10 +1,11 @@
-These directories come from outside.
+The subdirectories in this directory contain either copies or Conan recipes
+of external libraries used by rippled.
 The Conan recipes include patches we have not yet pushed upstream.
 
-| Folder          | Upstream Repo                                | Description |
+| Folder          | Upstream                                     | Description |
 |:----------------|:---------------------------------------------|:------------|
-| `ed25519-donna` | https://github.com/floodyberry/ed25519-donna | [Ed25519](http://ed25519.cr.yp.to/) digital signatures |
-| `rocksdb`       | https://github.com/conan-io/conan-center-index/tree/master/recipes/rocksdb | Fast key/value database. (Supports rotational disks better than NuDB.) |
-| `secp256k1`     | https://github.com/bitcoin-core/secp256k1    | ECDSA digital signatures using the **secp256k1** curve |
-| `snappy`        | https://github.com/conan-io/conan-center-index/tree/master/recipes/snappy  | "Snappy" lossless compression algorithm. |
-| `soci`          | https://github.com/conan-io/conan-center-index/tree/master/recipes/soci    | Abstraction layer for database access. |
+| `ed25519-donna` | [Project](https://github.com/floodyberry/ed25519-donna) | [Ed25519](http://ed25519.cr.yp.to/) digital signatures |
+| `rocksdb`       | [Recipe](https://github.com/conan-io/conan-center-index/tree/master/recipes/rocksdb) | Fast key/value database. (Supports rotational disks better than NuDB.) |
+| `secp256k1`     | [Project](https://github.com/bitcoin-core/secp256k1)    | ECDSA digital signatures using the **secp256k1** curve |
+| `snappy`        | [Recipe](https://github.com/conan-io/conan-center-index/tree/master/recipes/snappy)  | "Snappy" lossless compression algorithm. |
+| `soci`          | [Recipe](https://github.com/conan-io/conan-center-index/tree/master/recipes/soci)    | Abstraction layer for database access. |
diff --git a/src/ripple/beast/test/yield_to.h b/src/ripple/beast/test/yield_to.h
@@ -77,14 +77,16 @@ class enable_yield_to
 #if BEAST_DOXYGEN
     template <class... FN>
     void
-    yield_to(FN&&... fn)
+    yield_to(FN&&... fn);
 #else
     template <class F0, class... FN>
     void
     yield_to(F0&& f0, FN&&... fn);
 #endif
 
-        private : void spawn()
+private:
+    void
+    spawn()
     {
     }