-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate the dependence on certain boost modules that require linking. #216
Comments
Vinnie confirmed that adding C++11 dependencies carefully is OK. Testing is currently done only with 'npm test' - not sure whether this is enough. boost_random: Was able to remove the dependency and everything still built and ran. https://github.com/Wolfgang-Spraul/rippled/commit/780b65f6556065deb9f452a440205402c03c9f21 boost_date_time: Couldn't find dependency in ripple_app_pt3.o yet. |
Wow!!! How did you remove this dependency? By changing it to use std::random? Just an FYI...I believe Visual Studio 2012 implementation of has bugs. I'm not entirely sure. |
Yeah, please be VERY careful with modifying anything in regards to randomness, make sure you don't accidentially create a "Debian style" disaster! ;-) |
What a surprise...we didn't even need the library! That's great news. I will be integrating this soon. |
Yes true. And also saw the earlier poster about being careful with random - definitely! Very careful! I am really sorry about my slowness, too many daytime tasks. Issue 216 is totally great for me as it allows me to read through the rippled sources in a productive way. I will definitely continue, hopefully more things to come in the future. |
Merged. |
We can't fix this - we're hooked on Sorry! |
* Refactor Testcases (XRPLF#216) * remove unused function * add offer id tests * add escrow id tests * clang-format * fix offer * fix escrow * fix offer test
rippled relies on a small number of boost modules that are not header-only, and require linking against a library. They are:
We need to change the rippled code to eliminate the use of these modules one by one. There are simple alternatives for all of them, someone just needs to do the work (one module at a time).
A benefit of not requiring linking is that it will no longer be necessary to build boost (running bjam) but the bigger benefit is that we can insert the entire boost distribution directly in the rippled repository, so that everyone will be using the same version and there will be no hassle of install or configuration issues for boost.
The text was updated successfully, but these errors were encountered: