Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all the various RPC 'bad parameter' error codes with one #227

Closed
vinniefalco opened this issue Dec 17, 2013 · 0 comments
Closed

Comments

@vinniefalco
Copy link
Contributor

Instead of having rpcBAD_ISSUER, rpcBAD_MARKET, etc... we should just have one error code "rpcINVALID_PARAMS" (which already exists) and augment the returned JSON with information about which parameter is invalid, and why it is invalid. For example, we might add:

error_field : "taker_gets.currency"
error_problem : "parse error"

to indicate that the taker_gets["currency"] field in the JSON encountered a parsing error. This is much more robust and useful than having a proliferation of error codes. The other problem is that the current solution does not scale. Must we add a new error code for EVERY new JSON field? I sure hope not.

rec pushed a commit to rec/rippled that referenced this issue Sep 9, 2015
Per RFC6455 clients prefer to wait for servers to initiate TCP close.
timers ensure that clients don't wait forever. Servers close TCP
immediately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants