[TRIVIAL] Fix unneeded copies in range some range for loops: #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcobb23
previously approved these changes
Mar 25, 2020
| @@ -946,7 +946,7 @@ struct PayChan_test : public beast::unit_test::suite | |||
|
|
|||
| Env env(*this); | |||
| env.fund(XRP(10000), alice); | |||
| for (auto const a : bobs) | |||
| for (auto const& a : bobs) | |||
There was a problem hiding this comment.
Nit: Can you change a to b here? Same for line 993. Since the collection is called bobs, I think b is a better name. Also, on line 959, we iterate through bobs and name the element b.
There was a problem hiding this comment.
a for "account", but I don't mind changing it to b. Although that may take this out of the running for shortest patch - four characters!
There was a problem hiding this comment.
Ha! It's your call then. I don't mind either way.
seelabs
added
the
Ready to merge
clang 10 warns about an unneeded copy for these range for loops (range-loop-construct warnings)
cjcobb23
approved these changes
Apr 1, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang 10 warns about an unneeded copy for these range for
loops (range-loop-construct warnings)