Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosting a signers list public keys to a new location #3333

Conversation

manojsdoshi
Copy link
Contributor

Changing the location where we can store our public keys used to sign our packages.

@codecov-io
Copy link

Codecov Report

Merging #3333 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3333      +/-   ##
===========================================
- Coverage    70.61%   70.60%   -0.02%     
===========================================
  Files          676      676              
  Lines        54339    54339              
===========================================
- Hits         38374    38368       -6     
- Misses       15965    15971       +6     
Impacted Files Coverage Δ
src/ripple/server/impl/BaseHTTPPeer.h 87.57% <0.00%> (-3.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f00f263...10b3b3c. Read the comment docs.

Copy link
Contributor

@carlhua carlhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlhua carlhua added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Apr 7, 2020
@manojsdoshi manojsdoshi mentioned this pull request Apr 7, 2020
@MarkusTeufelberger
Copy link
Collaborator

As these are public keys, maybe these could be made publicly available anyways?

@manojsdoshi manojsdoshi mentioned this pull request Apr 7, 2020
@manojsdoshi manojsdoshi mentioned this pull request Apr 8, 2020
@manojsdoshi manojsdoshi deleted the update_package_signers_list_location branch May 27, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants