Update libarchive version

[yusufsahinhamza]

Fixes #3215
Tested with macOS Catalina (version 10.15)

[codecov-io]

Codecov Report

Merging #3367 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3367   +/-   ##
========================================
  Coverage    70.41%   70.41%           
========================================
  Files          683      683           
  Lines        54775    54775           
========================================
  Hits         38570    38570           
  Misses       16205    16205           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 020b285...ceb0f9a. Read the comment docs.

[nbougalis]

Thank you for your contribution.

[manojsdoshi]

LGTM

[thejohnfreeman]

Version 3.4.2 fails to build with Visual Studio 2017 because of unreachable code. @EricAustinYu diagnosed this problem in the libarchive project, and submitted a patch, but libarchive has not publicly acknowledged either yet. I would personally rather use a vanilla version between 3.3.3 and 3.4.2 that still fixes #3215 than apply patches during the build process.

[yusufsahinhamza]

@thejohnfreeman

Did you tried any version of libarchive between 3.3.3 and 3.4.2 for build rippled with Visual Studio 2017?

We can use 3.4.1 or 3.4.0 as you said if its fixes.

NOTE: 17 hours ago from now libarchive merged an PL (libarchive/libarchive#1364) for disabling MD5 errors, but i'm not sure when they are going to release it.

[thejohnfreeman]

I haven't tried any other versions, no, but as of now this PR is trading one build error on one platform for a different build error on a different platform. I think we should wait to upgrade our default version until libarchive releases one that has no build errors on any platforms. In the meantime, you should be able to override individual dependencies by installing them yourself and passing <PackageName>_ROOT to CMake.

[yusufsahinhamza]

Hi @thejohnfreeman and @manojsdoshi,

Finally they just released a new version of libarchive, v3.4.3.

They are already merged some pull requests (libarchive/libarchive#1364 & libarchive/libarchive#1360) about this issue so i will update the libarchive to it's latest version now.

[manojsdoshi]

LGTM