[TRIVIAL] Adjust frequency of mtENDPOINTS messages #3407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregtatcam
approved these changes
May 18, 2020
nbougalis
added
the
Ready to merge
| @@ -129,7 +129,8 @@ enum { | |||
| }; | |||
|
|
|||
| // How often we send or accept mtENDPOINTS messages per peer | |||
| static std::chrono::seconds const secondsPerMessage(5); | |||
| // (we use a prime number of purpose) | |||
There was a problem hiding this comment.
Which purpose?
This was referenced May 21, 2020
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously servers would send their peers
mtENDPOINTSmessages every 5 seconds. This is too often and for no real reason. Increase the frequency to 61 seconds (a prime number).