Log resource limit disconnections. #4035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcobb23
approved these changes
Dec 14, 2021
|
Code looks good but format check failed |
thejohnfreeman
approved these changes
Dec 14, 2021
natenichols
added
the
Ready to merge
ximinez
requested changes
Dec 15, 2021
| bool const d = m_logic->disconnect(*m_entry); | ||
| if (d) | ||
| { | ||
| JLOG(j.debug()) << "disconnecting " << entry().to_string(); |
There was a problem hiding this comment.
The rest of this function uses *m_entry, so using entry() here (which is equivalent other than asserting again) seems odd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mtrippled authored this commit.
High Level Overview of Change
Context of Change
Type of Change