Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] Reduce log level of "Unable to find ledger" message: fixes #3996. #4129

Closed
wants to merge 1 commit into from

Conversation

scottschurr
Copy link
Collaborator

High Level Overview of Change

GitHub issue #3996 notes a lot of unhelpful noise from the "Unable to find ledger ..." log message. The proposed change is to reduce the log level from warn() to debug().

Context of Change

Work to reduce noise in the log noted by GitHub issue #3996.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what is the context that causes this error to occur?

@scottschurr
Copy link
Collaborator Author

To me it looks like we're processing a request for a ledger from a peer. If the requested ledger is not available locally this message is generated. Doesn't really seem like a warn() is called for.

@scottschurr scottschurr added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Apr 13, 2022
@scottschurr
Copy link
Collaborator Author

Merged into 1.9.1-b1.

@scottschurr scottschurr deleted the unable-to-find-ledger branch April 30, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants