-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log exception messages in several locations #4400
Conversation
This is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
@@ -3566,7 +3570,7 @@ PeerImp::processLedgerRequest(std::shared_ptr<protocol::TMGetLedger> const& m) | |||
<< "processLedgerRequest: getNodeFat returns false"; | |||
} | |||
} | |||
catch (std::exception& e) | |||
catch (std::exception const& e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
@drlongle at your convenience, please do the following:
|
88f4956
to
8e1d824
Compare
I have resolved the conflicts and squashed the commits. The PR is ready to merge. |
Suggested commit message:
@drlongle please confirm this looks good, or suggest an alternative. |
@intelliot Looks good. Thanks! |
High Level Overview of Change
This PR resolves #3213 and logs exception messages at several locations.
Context of Change
At several locations in the code base, we catch an exception but do not log the exception messages. This PR adds code that logs the exception messages. This can be useful for analysis or debugging. The additional logging can have a (small) negative performance impact.
Type of Change