Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show DeliverMax in submit_multisigned etc if API v2 selected #4827

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Show DeliverMax in submit_multisigned etc if API v2 selected #4827

merged 3 commits into from
Nov 29, 2023
+6 −0

Conversation

Bronek
Copy link
Collaborator

@Bronek Bronek commented Nov 21, 2023 •
edited
Loading

High Level Overview of Change

Show DeliverMax instead of Amount in submit_multisigned etc. output if API version 2 was selected.

Context of Change

This was missed in #4733 and is meant to be released in API version 2

This resolves #4829

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Sorry, something went wrong.

@Bronek Bronek marked this pull request as ready for review November 21, 2023 16:36
@HowardHinnant HowardHinnant self-requested a review November 21, 2023 17:39
@seelabs seelabs self-requested a review November 21, 2023 17:40
@Bronek Bronek requested a review from seelabs November 21, 2023 18:25
seelabs
seelabs approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@seelabs seelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@intelliot intelliot merged commit fe8621b into XRPLF:develop Nov 29, 2023
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
@Bronek @sophiax851
APIv2: show DeliverMax in submit, submit_multisigned (XRPLF#4827)
7ee4150 
Show `DeliverMax` instead of `Amount` in output from `submit`,
`submit_multisigned`, `sign`, and `sign_for`.

Fix XRPLF#4829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seelabs seelabs

@HowardHinnant HowardHinnant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

[API V2 unexpectedly returns Amount field upon submitting a payment transaction] (Version: 2.0.0-b4)
4 participants
@Bronek @seelabs @HowardHinnant @intelliot