Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hubs.xrpkuwait.com to bootstrap #5166

Closed
wants to merge 2 commits into from
Closed

Conversation

alloynetworks
Copy link
Contributor

@Xrpkuwait is a committed contributor to XRPL infrastructure. His hubs will provide a much needed extra set of bootstrap servers. They have shown good uptime and capacity.

@Xrpkuwait is a committed contributor to XRPL infrastructure. His hubs will provide a much needed extra set of bootstrap servers.
Modified for CLANG formatting error
@alloynetworks alloynetworks changed the title Add hubs.xrpkuwait to bootstrap Add hubs.xrpkuwait.com to bootstrap Oct 29, 2024
@Xrpkuwait
Copy link

Thank you.

I confirm my commitment to operate the hubs.xrpkuwait.com servers for a minimum of 2 years.
XRPKuwait.com is an XRPL infrastructure provider based in Kuwait, operating 7 nodes, including public hubs and a validator.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.4%. Comparing base (63209c2) to head (49628e8).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5166     +/-   ##
=========================================
+ Coverage     76.1%   77.4%   +1.3%     
=========================================
  Files          762     762             
  Lines        61469   64936   +3467     
  Branches      8121    8120      -1     
=========================================
+ Hits         46807   50275   +3468     
+ Misses       14662   14661      -1     
Files with missing lines Coverage Δ
src/xrpld/overlay/detail/OverlayImpl.cpp 34.7% <100.0%> (+2.4%) ⬆️

... and 572 files with indirect coverage changes

Impacted file tree graph

Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the default list of servers in the example config https://github.com/XRPLF/rippled/blob/develop/cfg/rippled-example.cfg#L417-L419

@alloynetworks
Copy link
Contributor Author

Please also update the default list of servers in the example config https://github.com/XRPLF/rippled/blob/develop/cfg/rippled-example.cfg#L417-L419

Added via #5167

@alloynetworks alloynetworks requested a review from ximinez October 29, 2024 15:57
@ximinez
Copy link
Collaborator

ximinez commented Oct 29, 2024

Please also update the default list of servers in the example config https://github.com/XRPLF/rippled/blob/develop/cfg/rippled-example.cfg#L417-L419

Added via #5167

Sorry, my intention was that both changes would be included in this PR. It's one change that should be merged together, specifically using the "Squash and merge" button to put the changes into a single commit.

@alloynetworks
Copy link
Contributor Author

Combined with 5167 in 5169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants