-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect address in connectvity check report: #614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks fine to me. +1 |
Closed
The remoteAddress is the address as seen on the socket, which for incoming connections has a random port chosen by the remote implementation that is different from the port number used to accept connections by the remote listening socket. The checkedAddress is the remote address as seen on the socket, combined with the port advertised in the TMEndpoints message. This fixes the reporting and metadata associated with addresses tested for connectivity. The README has been updated to reflect that uptime is no longer part of the metadata associated with IP addresses saved for bootstrapping.
This is ready to go! 💯 |
Looks fine to me. |
Merged |
seelabs
added a commit
to seelabs/rippled
that referenced
this pull request
Jan 17, 2018
b5829e7e0 Fixed PostgreSQL BLOB destructor. 125753ff2 Merge pull request XRPLF#614 from Astrinus/master 1ea06a74a Merge pull request #1 from Astrinus/docs-refactoring efbc6c905 Fixed broken links in ada/reference.md 6fffb447c Fixed "statemETs" typo 66301072e Fixed broken links in client.md 6cb7a8355 Corrected table and added links to backends 549e9496d Fixed typo and broken link in multithreading.md 6eb048a62 Added missing parenthesis and fixed typo 34512ffad Fixed broken links in sqlite3.md 187ae3852 Fixed broken links and typos 38260d89e Fixed some typos in oracle.md a68698003 Fixed broken links and a typo in oracle.md 17ec47828 Fixed broken links on odbc.md 437871dd4 Fixed broken links and some typos on mysql.md 09cb2f0a6 Refix BLOB link in firebird.md 52d006dac Fix broken links in firebird.md 3ccdd69bc Fixed broken link in interfaces.md 187256316 Fixed broken link in statements.md 634846bc8 Refixed 3686325b9 Fixed broken links and corrected some typos de8dfe81a Fixed broken internal link 789e927b7 Fixed broken links on indicators.md 19617afb3 Fixed a typo in code 367c7df58 Fix broken links and minor typos on connections.md 356b8f30f Fix broken links in installation.md d27639d17 Added rowset & core interface interaction howto 8b00c6bd0 Merge pull request XRPLF#613 from seiyap70/patch-1 0cbc9f33c Throw a mysql exception git-subtree-dir: src/soci git-subtree-split: b5829e7e0fae53c5fbd06a0b15758fb943559515
seelabs
added a commit
to seelabs/rippled
that referenced
this pull request
Jan 18, 2018
b5829e7e0 Fixed PostgreSQL BLOB destructor. 125753ff2 Merge pull request XRPLF#614 from Astrinus/master 1ea06a74a Merge pull request #1 from Astrinus/docs-refactoring efbc6c905 Fixed broken links in ada/reference.md 6fffb447c Fixed "statemETs" typo 66301072e Fixed broken links in client.md 6cb7a8355 Corrected table and added links to backends 549e9496d Fixed typo and broken link in multithreading.md 6eb048a62 Added missing parenthesis and fixed typo 34512ffad Fixed broken links in sqlite3.md 187ae3852 Fixed broken links and typos 38260d89e Fixed some typos in oracle.md a68698003 Fixed broken links and a typo in oracle.md 17ec47828 Fixed broken links on odbc.md 437871dd4 Fixed broken links and some typos on mysql.md 09cb2f0a6 Refix BLOB link in firebird.md 52d006dac Fix broken links in firebird.md 3ccdd69bc Fixed broken link in interfaces.md 187256316 Fixed broken link in statements.md 634846bc8 Refixed 3686325b9 Fixed broken links and corrected some typos de8dfe81a Fixed broken internal link 789e927b7 Fixed broken links on indicators.md 19617afb3 Fixed a typo in code 367c7df58 Fix broken links and minor typos on connections.md 356b8f30f Fix broken links in installation.md d27639d17 Added rowset & core interface interaction howto 8b00c6bd0 Merge pull request XRPLF#613 from seiyap70/patch-1 0cbc9f33c Throw a mysql exception git-subtree-dir: src/soci git-subtree-split: b5829e7e0fae53c5fbd06a0b15758fb943559515
seelabs
added a commit
to seelabs/rippled
that referenced
this pull request
Mar 6, 2018
b5829e7e0 Fixed PostgreSQL BLOB destructor. 125753ff2 Merge pull request XRPLF#614 from Astrinus/master 1ea06a74a Merge pull request #1 from Astrinus/docs-refactoring efbc6c905 Fixed broken links in ada/reference.md 6fffb447c Fixed "statemETs" typo 66301072e Fixed broken links in client.md 6cb7a8355 Corrected table and added links to backends 549e9496d Fixed typo and broken link in multithreading.md 6eb048a62 Added missing parenthesis and fixed typo 34512ffad Fixed broken links in sqlite3.md 187ae3852 Fixed broken links and typos 38260d89e Fixed some typos in oracle.md a68698003 Fixed broken links and a typo in oracle.md 17ec47828 Fixed broken links on odbc.md 437871dd4 Fixed broken links and some typos on mysql.md 09cb2f0a6 Refix BLOB link in firebird.md 52d006dac Fix broken links in firebird.md 3ccdd69bc Fixed broken link in interfaces.md 187256316 Fixed broken link in statements.md 634846bc8 Refixed 3686325b9 Fixed broken links and corrected some typos de8dfe81a Fixed broken internal link 789e927b7 Fixed broken links on indicators.md 19617afb3 Fixed a typo in code 367c7df58 Fix broken links and minor typos on connections.md 356b8f30f Fix broken links in installation.md d27639d17 Added rowset & core interface interaction howto 8b00c6bd0 Merge pull request XRPLF#613 from seiyap70/patch-1 0cbc9f33c Throw a mysql exception git-subtree-dir: src/soci git-subtree-split: b5829e7e0fae53c5fbd06a0b15758fb943559515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remoteAddress is the address as seen on the socket, which for
incoming connections has a random port chosen by the remote implementation
that is different from the port number used to accept connections by the
remote listening socket. The checkedAddress is the remote address as seen
on the socket, combined with the port advertised in the TMEndpoints message.
This fixes the reporting and metadata associated with addresses tested
for connectivity.
@nbougalis @jjuran