Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect address in connectvity check report: #614

Closed
wants to merge 1 commit into from

Conversation

vinniefalco
Copy link
Contributor

The remoteAddress is the address as seen on the socket, which for
incoming connections has a random port chosen by the remote implementation
that is different from the port number used to accept connections by the
remote listening socket. The checkedAddress is the remote address as seen
on the socket, combined with the port advertised in the TMEndpoints message.
This fixes the reporting and metadata associated with addresses tested
for connectivity.
@nbougalis @jjuran

@nbougalis
Copy link
Contributor

This looks fine to me. +1

@vinniefalco vinniefalco mentioned this pull request Oct 9, 2014
The remoteAddress is the address as seen on the socket, which for
incoming connections has a random port chosen by the remote implementation
that is different from the port number used to accept connections by the
remote listening socket. The checkedAddress is the remote address as seen
on the socket, combined with the port advertised in the TMEndpoints message.
This fixes the reporting and metadata associated with addresses tested
for connectivity.

The README has been updated to reflect that uptime is no longer part of
the metadata associated with IP addresses saved for bootstrapping.
@vinniefalco
Copy link
Contributor Author

This is ready to go! 💯

@jjuran
Copy link
Contributor

jjuran commented Oct 9, 2014

Looks fine to me.

@vinniefalco
Copy link
Contributor Author

Merged

@vinniefalco vinniefalco closed this Oct 9, 2014
@vinniefalco vinniefalco deleted the checker branch October 10, 2014 22:19
seelabs added a commit to seelabs/rippled that referenced this pull request Jan 17, 2018
b5829e7e0 Fixed PostgreSQL BLOB destructor.
125753ff2 Merge pull request XRPLF#614 from Astrinus/master
1ea06a74a Merge pull request #1 from Astrinus/docs-refactoring
efbc6c905 Fixed broken links in ada/reference.md
6fffb447c Fixed "statemETs" typo
66301072e Fixed broken links in client.md
6cb7a8355 Corrected table and added links to backends
549e9496d Fixed typo and broken link in multithreading.md
6eb048a62 Added missing parenthesis and fixed typo
34512ffad Fixed broken links in sqlite3.md
187ae3852 Fixed broken links and typos
38260d89e Fixed some typos in oracle.md
a68698003 Fixed broken links and a typo in oracle.md
17ec47828 Fixed broken links on odbc.md
437871dd4 Fixed broken links and some typos on mysql.md
09cb2f0a6 Refix BLOB link in firebird.md
52d006dac Fix broken links in firebird.md
3ccdd69bc Fixed broken link in interfaces.md
187256316 Fixed broken link in statements.md
634846bc8 Refixed
3686325b9 Fixed broken links and corrected some typos
de8dfe81a Fixed broken internal link
789e927b7 Fixed broken links on indicators.md
19617afb3 Fixed a typo in code
367c7df58 Fix broken links and minor typos on connections.md
356b8f30f Fix broken links in installation.md
d27639d17 Added rowset & core interface interaction howto
8b00c6bd0 Merge pull request XRPLF#613 from seiyap70/patch-1
0cbc9f33c Throw a mysql exception

git-subtree-dir: src/soci
git-subtree-split: b5829e7e0fae53c5fbd06a0b15758fb943559515
seelabs added a commit to seelabs/rippled that referenced this pull request Jan 18, 2018
b5829e7e0 Fixed PostgreSQL BLOB destructor.
125753ff2 Merge pull request XRPLF#614 from Astrinus/master
1ea06a74a Merge pull request #1 from Astrinus/docs-refactoring
efbc6c905 Fixed broken links in ada/reference.md
6fffb447c Fixed "statemETs" typo
66301072e Fixed broken links in client.md
6cb7a8355 Corrected table and added links to backends
549e9496d Fixed typo and broken link in multithreading.md
6eb048a62 Added missing parenthesis and fixed typo
34512ffad Fixed broken links in sqlite3.md
187ae3852 Fixed broken links and typos
38260d89e Fixed some typos in oracle.md
a68698003 Fixed broken links and a typo in oracle.md
17ec47828 Fixed broken links on odbc.md
437871dd4 Fixed broken links and some typos on mysql.md
09cb2f0a6 Refix BLOB link in firebird.md
52d006dac Fix broken links in firebird.md
3ccdd69bc Fixed broken link in interfaces.md
187256316 Fixed broken link in statements.md
634846bc8 Refixed
3686325b9 Fixed broken links and corrected some typos
de8dfe81a Fixed broken internal link
789e927b7 Fixed broken links on indicators.md
19617afb3 Fixed a typo in code
367c7df58 Fix broken links and minor typos on connections.md
356b8f30f Fix broken links in installation.md
d27639d17 Added rowset & core interface interaction howto
8b00c6bd0 Merge pull request XRPLF#613 from seiyap70/patch-1
0cbc9f33c Throw a mysql exception

git-subtree-dir: src/soci
git-subtree-split: b5829e7e0fae53c5fbd06a0b15758fb943559515
seelabs added a commit to seelabs/rippled that referenced this pull request Mar 6, 2018
b5829e7e0 Fixed PostgreSQL BLOB destructor.
125753ff2 Merge pull request XRPLF#614 from Astrinus/master
1ea06a74a Merge pull request #1 from Astrinus/docs-refactoring
efbc6c905 Fixed broken links in ada/reference.md
6fffb447c Fixed "statemETs" typo
66301072e Fixed broken links in client.md
6cb7a8355 Corrected table and added links to backends
549e9496d Fixed typo and broken link in multithreading.md
6eb048a62 Added missing parenthesis and fixed typo
34512ffad Fixed broken links in sqlite3.md
187ae3852 Fixed broken links and typos
38260d89e Fixed some typos in oracle.md
a68698003 Fixed broken links and a typo in oracle.md
17ec47828 Fixed broken links on odbc.md
437871dd4 Fixed broken links and some typos on mysql.md
09cb2f0a6 Refix BLOB link in firebird.md
52d006dac Fix broken links in firebird.md
3ccdd69bc Fixed broken link in interfaces.md
187256316 Fixed broken link in statements.md
634846bc8 Refixed
3686325b9 Fixed broken links and corrected some typos
de8dfe81a Fixed broken internal link
789e927b7 Fixed broken links on indicators.md
19617afb3 Fixed a typo in code
367c7df58 Fix broken links and minor typos on connections.md
356b8f30f Fix broken links in installation.md
d27639d17 Added rowset & core interface interaction howto
8b00c6bd0 Merge pull request XRPLF#613 from seiyap70/patch-1
0cbc9f33c Throw a mysql exception

git-subtree-dir: src/soci
git-subtree-split: b5829e7e0fae53c5fbd06a0b15758fb943559515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants