Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support DynamicNFT XLS-46 #799
support DynamicNFT XLS-46 #799
Changes from 15 commits
29468e7
208d969
a2fe883
20885b3
d70f8fe
1038ef7
9b3ae2e
8dd215c
f7b8144
910fb14
e957057
7127172
af12b66
ef93b07
7b1adc1
d2b8b6c
e40614d
bb3c8fd
b02c39c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add more test cases for comprehensive coverage.
The current test suite should be expanded to include:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add NFTokenID format validation.
The
nftoken_id
field should validate that it matches the XRP Ledger's NFTokenID format to prevent runtime errors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add validation for hex-encoded URI format.
The URI documentation states it must be hex-encoded, but the
_get_uri_error
method only validates length and emptiness. Consider adding validation for hex format.📝 Committable suggestion