Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for disallowIncoming flags #2221

Merged
merged 5 commits into from
Feb 21, 2023
Merged

Add support for disallowIncoming flags #2221

merged 5 commits into from
Feb 21, 2023

Conversation

JST5000
Copy link
Contributor

@JST5000 JST5000 commented Feb 17, 2023

High Level Overview of Change

Adding client library support for the disallowIncoming amendment being proposed soon: XRPLF/rippled#4336

Context of Change

Adds 4 more account flags for disallowing incoming objects on the ledger.

Type of Change

  • New feature (non-breaking change which adds functionality)

Before / After

  • Adds `lsfDisallowIncomingNFTokenOffer

Test Plan

CI Passes

jonathanlei
jonathanlei approved these changes Feb 18, 2023
View reviewed changes
Copy link

@jonathanlei jonathanlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JST5000 JST5000 merged commit 3d0bec7 into main Feb 21, 2023
@JST5000 JST5000 deleted the add-new-flags branch February 21, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanlei jonathanlei jonathanlei approved these changes

@justinr1234 justinr1234 justinr1234 approved these changes

@ckniffen ckniffen ckniffen approved these changes

@khancode khancode Awaiting requested review from khancode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JST5000 @ckniffen @justinr1234 @jonathanlei