This repository has been archived by the owner on Jan 17, 2022. It is now read-only.
Fix path to build tools #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FejZa
requested review from
a team and
SimonDarksideJ
and removed request for
a team
FejZa
added
the
Ready for review
…v/editor-assembly-cleanup
SimonDarksideJ
approved these changes
Jan 13, 2021
StephenHodgson
approved these changes
Jan 13, 2021
|
This is quite the breaking change. |
|
I don't really see this as a big breaking change, since most of the changes are internal and unlikely to be used by real projects. |
|
I know of at least 7 external projects |
|
It's fine I work on most of them. I'll reach out to others |
|
Thanks @StephenHodgson, better to make this change now. It will also probably still take some time until it reached the master branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the path to build utilities in the buidl step. XRTK/com.xrtk.core#753 depends on this change to pass buld verification.